[llvm] [GlobalIsel] Lower integer constants to constant pool in `LegalizerHelper`. (PR #81957)

via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 15 17:29:12 PST 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 7192c22ee43500b1a6313d1ade38e002463944a6 e1f926dc9ce0be60480dc563a70972a48add5343 -- llvm/include/llvm/CodeGen/GlobalISel/LegalizerHelper.h llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp b/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
index e5450d36cb..4622686729 100644
--- a/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
+++ b/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
@@ -2987,9 +2987,8 @@ static void getUnmergePieces(SmallVectorImpl<Register> &Pieces,
     Pieces.push_back(Unmerge.getReg(I));
 }
 
-static void emitLoadFromConstantPool(
-    Register DstReg, const Constant *ConstVal,
-    MachineIRBuilder &MIRBuilder) {
+static void emitLoadFromConstantPool(Register DstReg, const Constant *ConstVal,
+                                     MachineIRBuilder &MIRBuilder) {
   MachineRegisterInfo &MRI = *MIRBuilder.getMRI();
   MachineFunction &MF = MIRBuilder.getMF();
   const DataLayout &DL = MIRBuilder.getDataLayout();
@@ -3013,7 +3012,7 @@ static void emitLoadFromConstantPool(
 LegalizerHelper::LegalizeResult
 LegalizerHelper::lowerConstant(MachineInstr &MI) {
   MachineOperand ConstOperand = MI.getOperand(1);
-  assert (ConstOperand.isCImm());
+  assert(ConstOperand.isCImm());
   const Constant *ConstantVal = ConstOperand.getCImm();
 
   emitLoadFromConstantPool(MI.getOperand(0).getReg(), ConstantVal, MIRBuilder);
@@ -3025,7 +3024,7 @@ LegalizerHelper::lowerConstant(MachineInstr &MI) {
 LegalizerHelper::LegalizeResult
 LegalizerHelper::lowerFConstant(MachineInstr &MI) {
   MachineOperand ConstOperand = MI.getOperand(1);
-  assert (ConstOperand.isFPImm());
+  assert(ConstOperand.isFPImm());
   const Constant *ConstantVal = ConstOperand.getFPImm();
 
   emitLoadFromConstantPool(MI.getOperand(0).getReg(), ConstantVal, MIRBuilder);

``````````

</details>


https://github.com/llvm/llvm-project/pull/81957


More information about the llvm-commits mailing list