[llvm] llvm-dwarfdump --verify aggregated output to JSON file (PR #81762)

Greg Clayton via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 15 11:11:40 PST 2024


================
@@ -836,6 +842,8 @@ int main(int argc, char **argv) {
   }
   if (!Verify && ErrorDetails != Unspecified)
     WithColor::warning() << "-error-detail has no affect without -verify";
+  if (!Verify && !JsonSummaryFile.empty())
+    WithColor::warning() << "-json-summary-file has no affect without -verify";
----------------
clayborg wrote:

He might be asking if we just need to supply `--json-summary-file` and that would enable verify automatically? But I would like it to be clear that this flag goes with `--verify`. Maybe `--json-verify-results-file`?

Or can we have optional values for the existing `--verify` so it would be:
```
--verify
--verify=text
--verify=json
```
Where `--verify` takes an optional enum parameter: `(text|json)` and it defaults to `text`? I am not sure this make sense though

https://github.com/llvm/llvm-project/pull/81762


More information about the llvm-commits mailing list