[llvm] [CodeGen][ShrinkWrap] Clarify StackAddressUsedBlockInfo meaning (PR #80679)
Quentin Colombet via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 15 01:44:01 PST 2024
================
@@ -161,9 +161,9 @@ class ShrinkWrap : public MachineFunctionPass {
/// Current MachineFunction.
MachineFunction *MachineFunc = nullptr;
- /// Is `true` for block numbers where we can guarantee no stack access
- /// or computation of stack-relative addresses on any CFG path including
- /// the block itself.
+ /// Is `true` for the block numbers where we cannot guarantee that there will
+ /// be no access to the stack or computation of stack-relative addresses on
+ /// any CFG path including the block itself.
----------------
qcolombet wrote:
Yes, that’s I said “may”.
And call out the false case. Essentially we case have false positive, I.e., we are conservative to remain correct.
Feel free to rephrase!
https://github.com/llvm/llvm-project/pull/80679
More information about the llvm-commits
mailing list