[llvm] [llvm][AArch64] Do not inline a function with different signing scheme. (PR #80642)

via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 14 14:23:09 PST 2024


DanielKristofKiss wrote:

> Also, consider submitting your 3 commits as 3 distinct PRs. The first is ready to land. I think the auto upgrade could be detached from the inlining decisions.

Sorry, messed up this one as other patches went up separately already: 
https://github.com/llvm/llvm-project/pull/80640 ( I'll update that with the comment here)
https://github.com/llvm/llvm-project/pull/80465 

> Also, I'm kind of surprised you didn't have to change anything in clang codegen of LLVM IR. Shouldn't clang now be generating fn attrs rather than module attrs? Was there a different PR for that?

Clang can't really do much here as we add more functions to the module during later passes ( c++ exception handler, sanitisers especially). So the right thing is to derive the attributes from the module flag. Autoupgrade now do this at the last moment before the functions merged into the common module. 


https://github.com/llvm/llvm-project/pull/80642


More information about the llvm-commits mailing list