[llvm] [AMDGPU] Refactor export instruction definitions. NFC. (PR #81738)
Ivan Kosarev via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 14 06:20:21 PST 2024
================
@@ -10,21 +10,24 @@
// EXP classes
//===----------------------------------------------------------------------===//
-class EXPCommon<bit row, bit done, string asm = ""> : InstSI<
+class EXPCommon<bit _row, bit _done, string asm = ""> : InstSI<
(outs),
(ins exp_tgt:$tgt,
ExpSrc0:$src0, ExpSrc1:$src1, ExpSrc2:$src2, ExpSrc3:$src3,
exp_vm:$vm, exp_compr:$compr, i32imm:$en),
asm> {
let EXP = 1;
let EXP_CNT = 1;
- let mayLoad = done;
+ let mayLoad = _done;
let mayStore = 1;
let maybeAtomic = 0;
let UseNamedOperandTable = 1;
- let Uses = !if(row, [EXEC, M0], [EXEC]);
+ let Uses = !if(_row, [EXEC, M0], [EXEC]);
let SchedRW = [WriteExport];
let DisableWQM = 1;
+
+ bit row = _row;
+ bit done = _done;
----------------
kosarev wrote:
What if capitalise the names as we do with other fields instead of adding underscore, `bit Row = row`?
https://github.com/llvm/llvm-project/pull/81738
More information about the llvm-commits
mailing list