[compiler-rt] [Sanitizers][ABI] Remove too strong assert in asan_abi_shim (PR #81696)

via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 13 19:38:08 PST 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Mariusz Borsa (wrotki)

<details>
<summary>Changes</summary>

Recently we enabled building the shim for arm64_32 arch. On this arch, sizeof(uptr) == sizeof(unsigned long) == 4 - so this assert will fail in runtime.

Need to just remove this assert

rdar://122927166


---
Full diff: https://github.com/llvm/llvm-project/pull/81696.diff


1 Files Affected:

- (modified) compiler-rt/lib/asan_abi/asan_abi_shim.cpp (-1) 


``````````diff
diff --git a/compiler-rt/lib/asan_abi/asan_abi_shim.cpp b/compiler-rt/lib/asan_abi/asan_abi_shim.cpp
index 35c45dff96f6d2..523b322618b850 100644
--- a/compiler-rt/lib/asan_abi/asan_abi_shim.cpp
+++ b/compiler-rt/lib/asan_abi/asan_abi_shim.cpp
@@ -54,7 +54,6 @@ void *__asan_memmove(void *dest, const void *src, uptr n) {
 
 // Functions concerning RTL startup and initialization
 void __asan_init(void) {
-  static_assert(sizeof(uptr) == 8);
   static_assert(sizeof(u64) == 8);
   static_assert(sizeof(u32) == 4);
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/81696


More information about the llvm-commits mailing list