[llvm] [AArch64] Implement -fno-plt for SelectionDAG/GlobalISel (PR #78890)
Fangrui Song via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 13 11:08:58 PST 2024
================
@@ -1293,8 +1293,19 @@ bool AArch64CallLowering::lowerCall(MachineIRBuilder &MIRBuilder,
!Subtarget.noBTIAtReturnTwice() &&
MF.getInfo<AArch64FunctionInfo>()->branchTargetEnforcement())
Opc = AArch64::BLR_BTI;
- else
+ else {
+ // For an intrinsic call (e.g. memset), use GOT if "RtLibUseGOT" (-fno-plt)
+ // is set.
+ if (Info.Callee.isSymbol() && F.getParent()->getRtLibUseGOT()) {
+ auto Reg =
+ MRI.createGenericVirtualRegister(getLLTForType(*F.getType(), DL));
+ auto MIB = MIRBuilder.buildInstr(TargetOpcode::G_GLOBAL_VALUE);
+ DstOp(Reg).addDefToMIB(MRI, MIB);
----------------
MaskRay wrote:
I disagree. I think adding a function similar to `buildGlobalValue`, either omits `const GlobalValue *GV` or changes the argument to `const char*`, will add confusion, as this is a very special use case.
I slightly simplified the code in the just-pushed commit.
https://github.com/llvm/llvm-project/pull/78890
More information about the llvm-commits
mailing list