[llvm] MIPS/Asm/O32: Don't add another $ to PrivateGlobal symbol (PR #80644)
Fangrui Song via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 13 00:31:10 PST 2024
================
@@ -2920,6 +2920,11 @@ bool MipsAsmParser::loadAndAddSymbolAddress(const MCExpr *SymExpr,
(Res.getSymA()->getSymbol().isELF() &&
cast<MCSymbolELF>(Res.getSymA()->getSymbol()).getBinding() ==
ELF::STB_LOCAL);
+ if (!IsLocalSym && ABI.IsO32()) {
+ // PrivateGlobalPrefix for O32 is '$', while we support '.L' anyway.
----------------
MaskRay wrote:
This comment is confusing.
// For O32, "$"-prefixed symbols are recognized as temporary while .L-prefixed symbols are not (PrivateGlobalPrefix is "$"). Recognize ".L" manually.
https://github.com/llvm/llvm-project/pull/80644
More information about the llvm-commits
mailing list