[llvm] [BOLT][NFC] Return Error from BinaryFunctionPass::runOnFunctions (PR #81521)

[Rafael Auler via llvm-commits]

https://github.com/rafaelauler approved this pull request.

Thanks, Amir. As commit message I think we can put something like:

As part of the effort to refactor old error handling code that
would directly call exit(1), in this patch we change the
interface to BinaryFunctionPass to return an Error on
runOnFunctions(). This gives passes the ability to report a
serious problem to the caller (RewriteInstance class), so the
caller may decide how to best handle the exceptional situation.




https://github.com/llvm/llvm-project/pull/81521