[llvm] [CAS] LLVMCAS implementation (PR #68448)

Steven Wu via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 12 09:06:24 PST 2024


cachemeifyoucan wrote:

> Hello @cachemeifyoucan! Do you still plan on working on these PRs? There were some unaddressed comments/requests for changes left last year.
> 
> +1 with @dwblaikie - this would need to be split in smaller patches, there's just too much code to review. Can you send a PR for the `Path` changes? Can you send another PR for the basic/most indivisible interfaces with mock implementations in unit tests? I think you could then send specific implementations one by one. And finish with `llvm-cas` and the LLVM C APIs? My impression is that everyone agrees that we need all this.

Hi @aganea Thanks for helping with the review! I was distracted with other obligation that I temporary unable to follow up with the reviews and I definitely intended to pick this up ASAP. Note this PR was created just as we transition to GitHub PR that there isn't a clear workflow for how to handle a big PR like this. I was breaking up the big commit into smaller reviews (like https://github.com/llvm/llvm-project/pull/69528) while using this PR to provide a larger context. I might take some time to rewrite this PR using `spr`. I will remember to add you as reviewer in future PR.


> FWIW we build something like this a while ago: https://github.com/legion-labs/legion/tree/main/crates/lgn-content-store

Cool! Glad to see more community members are doing something similar and we hope we can work together!

 

https://github.com/llvm/llvm-project/pull/68448


More information about the llvm-commits mailing list