[llvm] [libc][bazel] mark epoll funcitons as weak (PR #81327)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 9 14:45:30 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libc
Author: None (michaelrj-google)
<details>
<summary>Changes</summary>
Downstream there's a user that intercepts these functions and overlays
them. This causes symbol conflicts if neither function is marked weak.
In future the intent is to move to this to being a downstream configuration
option.
---
Full diff: https://github.com/llvm/llvm-project/pull/81327.diff
1 Files Affected:
- (modified) utils/bazel/llvm-project-overlay/libc/BUILD.bazel (+3)
``````````diff
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index fd6d1dc047f428..e2e1daf365acdc 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -3216,6 +3216,7 @@ libc_function(
name = "epoll_wait",
srcs = ["src/sys/epoll/linux/epoll_wait.cpp"],
hdrs = ["src/sys/epoll/epoll_wait.h"],
+ weak = True,
deps = [
":__support_osutil_syscall",
":errno",
@@ -3226,6 +3227,7 @@ libc_function(
name = "epoll_pwait",
srcs = ["src/sys/epoll/linux/epoll_pwait.cpp"],
hdrs = ["src/sys/epoll/epoll_pwait.h"],
+ weak = True,
deps = [
":__support_osutil_syscall",
":errno",
@@ -3238,6 +3240,7 @@ libc_function(
# name = "epoll_pwait2",
# srcs = ["src/sys/epoll/linux/epoll_pwait2.cpp"],
# hdrs = ["src/sys/epoll/epoll_pwait2.h"],
+# weak = True,
# deps = [
# ":__support_osutil_syscall",
# ":errno",
``````````
</details>
https://github.com/llvm/llvm-project/pull/81327
More information about the llvm-commits
mailing list