[llvm] [DWARFDump][nfc] Fix incorrect comment (PR #81276)

Felipe de Azevedo Piovezan via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 9 08:51:32 PST 2024


https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/81276

It claimed to dump all sections by default, but this hasn't been true since 2017: https://reviews.llvm.org/D37717

>From c82ae2f7addbf7d137aa5ff52264b1c188fa66a8 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan <fpiovezan at apple.com>
Date: Fri, 9 Feb 2024 08:39:25 -0800
Subject: [PATCH] [DWARFDump][nfc] Fix incorrect comment

It claimed to dump all sections by default, but this hasn't been true since
2017: https://reviews.llvm.org/D37717
---
 llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp b/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
index 559e7a60489834..74dc519c947726 100644
--- a/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
+++ b/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
@@ -845,8 +845,8 @@ int main(int argc, char **argv) {
 
   bool OffsetRequested = false;
 
-  // Defaults to dumping all sections, unless brief mode is specified in which
-  // case only the .debug_info section in dumped.
+  // Defaults to dumping only debug_info, unless verbose mode is specified in
+  // which case all sections are dumped.
 #define HANDLE_DWARF_SECTION(ENUM_NAME, ELF_NAME, CMDLINE_NAME, OPTION)        \
   if (Dump##ENUM_NAME.IsRequested) {                                           \
     DumpType |= DIDT_##ENUM_NAME;                                              \



More information about the llvm-commits mailing list