[lld] [ELF] --no-rosegment: don't mark read-only PT_LOAD segments executable (PR #81223)

Peter Smith via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 9 08:06:03 PST 2024


================
@@ -2451,7 +2446,7 @@ SmallVector<PhdrEntry *, 0> Writer<ELFT>::createPhdrs(Partition &part) {
     // Segments are contiguous memory regions that has the same attributes
     // (e.g. executable or writable). There is one phdr for each segment.
     // Therefore, we need to create a new phdr when the next section has
-    // different flags or is loaded at a discontiguous address or memory region
+    // compatible flags or is loaded at a discontiguous address or memory region
----------------
smithp35 wrote:

Did you mean "create a new phdr when the next section has incompatible flags"?

https://github.com/llvm/llvm-project/pull/81223


More information about the llvm-commits mailing list