[llvm] 9347146 - Document use of `skip-precommit-approval` label for non-review pull requests (#81053)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 8 16:41:08 PST 2024
Author: David Blaikie
Date: 2024-02-08T16:41:04-08:00
New Revision: 93471466be65cf78330782d461a821ffb82e070a
URL: https://github.com/llvm/llvm-project/commit/93471466be65cf78330782d461a821ffb82e070a
DIFF: https://github.com/llvm/llvm-project/commit/93471466be65cf78330782d461a821ffb82e070a.diff
LOG: Document use of `skip-precommit-approval` label for non-review pull requests (#81053)
Derived from this discussion:
https://discourse.llvm.org/t/prs-without-approvals-muddy-the-waters/76656
Added:
Modified:
llvm/docs/CodeReview.rst
llvm/docs/GitHub.rst
Removed:
################################################################################
diff --git a/llvm/docs/CodeReview.rst b/llvm/docs/CodeReview.rst
index f1d5b6c9c99206..e3a74946e5933b 100644
--- a/llvm/docs/CodeReview.rst
+++ b/llvm/docs/CodeReview.rst
@@ -103,6 +103,12 @@ ready to be committed. Specifically, once a patch is sent out for review, it
needs an explicit approval before it is committed. Do not assume silent
approval, or solicit objections to a patch with a deadline.
+.. note::
+ If you are using a Pull Request for purposes other than review
+ (eg: precommit CI results, convenient web-based reverts, etc)
+ `skip-precommit-approval<https://github.com/llvm/llvm-project/labels?q=skip-precommit-approval>`
+ label to the PR.
+
Acknowledge All Reviewer Feedback
---------------------------------
diff --git a/llvm/docs/GitHub.rst b/llvm/docs/GitHub.rst
index c3fbb64c2dd96a..51a7310a8a72d5 100644
--- a/llvm/docs/GitHub.rst
+++ b/llvm/docs/GitHub.rst
@@ -30,6 +30,12 @@ describes the typical workflow of creating a Pull Request and getting it reviewe
and accepted. This is meant as an overview of the GitHub workflow, for complete
documentation refer to `GitHub's documentation <https://docs.github.com/pull-requests>`_.
+.. note::
+ If you are using a Pull Request for purposes other than review
+ (eg: precommit CI results, convenient web-based reverts, etc)
+ `skip-precommit-approval<https://github.com/llvm/llvm-project/labels?q=skip-precommit-approval>`
+ label to the PR.
+
GitHub Tools
------------
You can interact with GitHub in several ways: via git command line tools,
More information about the llvm-commits
mailing list