[libcxx] [llvm] [docs] Fix malformed csv files (PR #80567)

via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 8 12:00:12 PST 2024


wusatosi wrote:

> @wusatosi What dependencies do you need to implement this check? If there are basically no dependencies that need to be installed, I would add it so that it gets checked as part of `check-cxx`, I think. But otherwise I would probably add it to `.github/workflows/libcxx-check-generated-files.yml` (and rename that file to something like `libcxx-lightweight-checks.yml`.

Thanks for the reply, a simple python script should be sufficient, I don't think we need another Action.

I am not familiar with the CI so I don't really understand what "check-cxx" pipeline you are referring to.

By name, it looks like `Test documentation build` and `check code formatting` pipelines sounds like a good place to put in, though technically broken CSV doesn't break the documentation generation. 

Is there any CI person I can consult on where to put this check in?

https://github.com/llvm/llvm-project/pull/80567


More information about the llvm-commits mailing list