[llvm] [DWARFLinkerParallel] Fix member initializer order (PR #81179)
Fangrui Song via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 8 11:30:46 PST 2024
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/81179
DWARFLinkerImpl::DWARFLinkerImpl initializes
DebugStrStrings/DebugLineStrStrings/CommonSections using GlobalData
but GlobalData is initialized after the three members.
Move GlobalData before.
Fix #81110
>From 1d4317798bbdf2c51f4fd7893d0328dbbd5575ee Mon Sep 17 00:00:00 2001
From: Fangrui Song <i at maskray.me>
Date: Thu, 8 Feb 2024 11:30:37 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
=?UTF-8?q?l=20version?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Created using spr 1.3.4
---
llvm/lib/DWARFLinker/Parallel/DWARFLinkerImpl.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/llvm/lib/DWARFLinker/Parallel/DWARFLinkerImpl.h b/llvm/lib/DWARFLinker/Parallel/DWARFLinkerImpl.h
index 527c7a0ec3642f..7c17c5b79c7c18 100644
--- a/llvm/lib/DWARFLinker/Parallel/DWARFLinkerImpl.h
+++ b/llvm/lib/DWARFLinker/Parallel/DWARFLinkerImpl.h
@@ -351,6 +351,9 @@ class DWARFLinkerImpl : public DWARFLinker {
/// \defgroup Data members accessed sequentially.
///
/// @{
+ /// Data global for the whole linking process.
+ LinkingGlobalData GlobalData;
+
/// DwarfStringPoolEntries for .debug_str section.
StringEntryToDwarfStringPoolEntryMap DebugStrStrings;
@@ -368,9 +371,6 @@ class DWARFLinkerImpl : public DWARFLinker {
/// Overall compile units number.
uint64_t OverallNumberOfCU = 0;
-
- /// Data global for the whole linking process.
- LinkingGlobalData GlobalData;
/// @}
};
More information about the llvm-commits
mailing list