[llvm] 13c14ad - Revert "[DebugInfo][RemoveDIs] Turn on non-instrinsic debug-info by default"

[Jeremy Morse via llvm-commits]

Author: Jeremy Morse
Date: 2024-02-08T18:20:37Z
New Revision: 13c14ad42c65e154dc079332dd5dd58e8925d26c

URL: https://github.com/llvm/llvm-project/commit/13c14ad42c65e154dc079332dd5dd58e8925d26c
DIFF: https://github.com/llvm/llvm-project/commit/13c14ad42c65e154dc079332dd5dd58e8925d26c.diff

LOG: Revert "[DebugInfo][RemoveDIs] Turn on non-instrinsic debug-info by default"

This reverts commit bdde5f9bea75e897bcc31a95b9c3376988c211cc.

Two situations that are tripping a few buildbots:

  https://lab.llvm.org/buildbot/#/builders/205/builds/25126

Here, polly is currently presenting a DebugLoc attached to a debugging
intrinsic as a "true" source location in a user report, something that's
unreliable.

  https://lab.llvm.org/buildbot/#/builders/184/builds/10242

These HWAsan failures are probably (97% confidence) because in
StackInfoBuilder::visit we're not observing DPValues attached to lifetime
intrinsics because they're delt with higher up the function.

But it's late-o'clock here, so revert for now.

Added: 
    

Modified: 
    llvm/lib/IR/BasicBlock.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/IR/BasicBlock.cpp b/llvm/lib/IR/BasicBlock.cpp
index bf02eba9fb448d..fe9d0d08c5fe97 100644
--- a/llvm/lib/IR/BasicBlock.cpp
+++ b/llvm/lib/IR/BasicBlock.cpp
@@ -34,7 +34,7 @@ cl::opt<bool>
     UseNewDbgInfoFormat("experimental-debuginfo-iterators",
                         cl::desc("Enable communicating debuginfo positions "
                                  "through iterators, eliminating intrinsics"),
-                        cl::init(true));
+                        cl::init(false));
 
 DPMarker *BasicBlock::createMarker(Instruction *I) {
   assert(IsNewDbgInfoFormat &&