[llvm] [GlobalISel][TableGen] Take first result for multi-output instructions (PR #81130)
Pierre van Houtryve via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 8 05:22:17 PST 2024
================
@@ -288,11 +288,21 @@ static std::string getMangledRootDefName(StringRef DefOperandName) {
//===- GlobalISelEmitter class --------------------------------------------===//
-static Expected<LLTCodeGen> getInstResultType(const TreePatternNode *Dst) {
+static Expected<LLTCodeGen> getInstResultType(const TreePatternNode *Dst,
+ const CodeGenTarget &Target) {
+ // While allowing more than one output (both implicit and explicit defs)
+ // below, we only expect one explicit def here.
+ assert(Dst->getOperator()->isSubClassOf("Instruction"));
+ CodeGenInstruction &InstInfo = Target.getInstruction(Dst->getOperator());
+ if (InstInfo.Operands.NumDefs != 1)
----------------
Pierre-vh wrote:
why do we need to enforce only one def?
for `v_mad_u64_u32` I'd need to allow 2 defs I think
https://github.com/llvm/llvm-project/pull/81130
More information about the llvm-commits
mailing list