[lld] [llvm] [Object][Wasm] Use file offset for section addresses in linked wasm files (PR #80529)

Sam Clegg via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 7 08:40:43 PST 2024


================
@@ -1366,8 +1375,9 @@ static SymbolInfoTy createDummySymbolInfo(const ObjectFile &Obj,
                                           uint8_t Type) {
   if (Obj.isXCOFF() && (SymbolDescription || TracebackTable))
     return SymbolInfoTy(std::nullopt, Addr, Name, std::nullopt, false);
-  else
-    return SymbolInfoTy(Addr, Name, Type);
+  if (Obj.isWasm())
+    return SymbolInfoTy(Addr, Name, wasm::WASM_SYMBOL_TYPE_SECTION);
----------------
sbc100 wrote:

This function takes `Type` argument.. can we not use that?  Why ignore it?  (Full disclosure, I don't know what this function is for).

https://github.com/llvm/llvm-project/pull/80529


More information about the llvm-commits mailing list