[llvm] [RemoveDIs] Don't convert debug-info in bitcode-loading just now (PR #80865)

Jeremy Morse via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 7 03:12:12 PST 2024


================
@@ -1775,6 +1775,8 @@ IRMover::IRMover(Module &M) : Composite(M) {
 Error IRMover::move(std::unique_ptr<Module> Src,
                     ArrayRef<GlobalValue *> ValuesToLink,
                     LazyCallback AddLazyFor, bool IsPerformingImport) {
+  if (getModule().IsNewDbgInfoFormat)
+    Src->convertToNewDbgValues();
----------------
jmorse wrote:

"Probably yes" -- with this patch it's only the pass manager that's going to create modules in new-debug-info mode, so any other module created Should(TM) be in dbg.value format. This seems to be the case in the llvm-lit test suite.

I'm 99.5% confident of this; but we've also got a bunch of assertions for the IsNewDbgInfoFormat flag to detect codepaths where this isn't the case. If it turns out to be wrong we'll hopefully break-fast-break-hard.

https://github.com/llvm/llvm-project/pull/80865


More information about the llvm-commits mailing list