[llvm] [DWARFYAML] Implement debug_names support (PR #79666)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 7 01:00:56 PST 2024


================
@@ -783,15 +784,15 @@ getNonZeroDataSizesFor(uint32_t AbbrevCode,
   });
   if (AbbrevIt == Abbrevs.end())
     return createStringError(inconvertibleErrorCode(),
-                             "Did not find an Abbreviation for this code");
+                             "did not find an Abbreviation for this code");
 
   SmallVector<uint8_t> DataSizes;
-  dwarf::FormParams Params{5 /*Version*/, 4 /*AddrSize*/, dwarf::DWARF32};
+  dwarf::FormParams Params{/*Version*/ 5, /*AddrSize*/ 4, dwarf::DWARF32};
----------------
jh7370 wrote:

Still missing the `=` from my original suggestion (i.e. `/*Version=*/5` and `/*AddrSize=*/4`).

https://github.com/llvm/llvm-project/pull/79666


More information about the llvm-commits mailing list