[llvm] Make two texts static in `ReplayInlineAdvisor` (PR #79489)

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 6 20:45:10 PST 2024


================
@@ -43,8 +43,8 @@ ReplayInlineAdvisor::ReplayInlineAdvisor(
   //   main:3:1.1;
   // We use the callsite string after `at callsite` to replay inlining.
   line_iterator LineIt(*BufferOrErr.get(), /*SkipBlanks=*/true);
-  const std::string PositiveRemark = "' inlined into '";
-  const std::string NegativeRemark = "' will not be inlined into '";
+  static const std::string PositiveRemark = "' inlined into '";
----------------
vitalybuka wrote:

You can use string ref here
```
StringRef PositiveRemark = "' inlined into '";
```

However I don't understand why you can report in code as is

https://github.com/llvm/llvm-project/pull/79489


More information about the llvm-commits mailing list