[llvm] [IRBuilder] Fold binary intrinsics (PR #80743)

via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 5 13:29:51 PST 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff d0b5d32ce6a6287ddab96b028db534cc1bd9a929 84a1fd55bb77d967e6a9195388f763d4af8e58f2 -- llvm/include/llvm/Analysis/InstSimplifyFolder.h llvm/include/llvm/Analysis/TargetFolder.h llvm/include/llvm/IR/ConstantFolder.h llvm/include/llvm/IR/IRBuilderFolder.h llvm/include/llvm/IR/NoFolder.h llvm/lib/IR/IRBuilder.cpp llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/include/llvm/Analysis/TargetFolder.h b/llvm/include/llvm/Analysis/TargetFolder.h
index cabce12541..ab879be0c6 100644
--- a/llvm/include/llvm/Analysis/TargetFolder.h
+++ b/llvm/include/llvm/Analysis/TargetFolder.h
@@ -191,7 +191,8 @@ public:
     return nullptr;
   }
 
-  Value *FoldBinaryIntrinsics(Intrinsic::ID ID, Value *LHS, Value *RHS) const override {
+  Value *FoldBinaryIntrinsics(Intrinsic::ID ID, Value *LHS,
+                              Value *RHS) const override {
     // TODO: should this be defined?
     return nullptr;
   }
diff --git a/llvm/include/llvm/IR/NoFolder.h b/llvm/include/llvm/IR/NoFolder.h
index 787dd10b4c..c31a4eb176 100644
--- a/llvm/include/llvm/IR/NoFolder.h
+++ b/llvm/include/llvm/IR/NoFolder.h
@@ -112,7 +112,8 @@ public:
     return nullptr;
   }
 
-  Value *FoldBinaryIntrinsics(Intrinsic::ID ID, Value *LHS, Value *RHS) const override {
+  Value *FoldBinaryIntrinsics(Intrinsic::ID ID, Value *LHS,
+                              Value *RHS) const override {
     return nullptr;
   }
 
diff --git a/llvm/lib/IR/IRBuilder.cpp b/llvm/lib/IR/IRBuilder.cpp
index e5015c1368..39d45e2c30 100644
--- a/llvm/lib/IR/IRBuilder.cpp
+++ b/llvm/lib/IR/IRBuilder.cpp
@@ -923,7 +923,7 @@ CallInst *IRBuilderBase::CreateBinaryIntrinsic(Intrinsic::ID ID, Value *LHS,
                                                Instruction *FMFSource,
                                                const Twine &Name) {
   if (Value *V = Folder.FoldBinaryIntrinsics(ID, LHS, RHS))
-    return (CallInst *) V; // TODO: should return value be changed to Value *?
+    return (CallInst *)V; // TODO: should return value be changed to Value *?
   Module *M = BB->getModule();
   Function *Fn = Intrinsic::getDeclaration(M, ID, { LHS->getType() });
   return createCallHelper(Fn, {LHS, RHS}, Name, FMFSource);

``````````

</details>


https://github.com/llvm/llvm-project/pull/80743


More information about the llvm-commits mailing list