[llvm] [RFC] Memory Model Relaxation Annotations (PR #78569)

Sameer Sahasrabuddhe via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 5 01:33:57 PST 2024


================
@@ -248,15 +260,19 @@ class MachineInstr
     size_t numTrailingObjects(OverloadToken<uint32_t>) const {
       return HasCFIType;
     }
+    size_t numTrailingObjects(OverloadToken<MMRAMetadata>) const {
----------------
ssahasra wrote:

I don't really grok how trailing objects are implemented, but this smells wrong to me. Shouldn't this function be folded into the overload for MDNode* just above? What makes this metadata different from the other metadata?

https://github.com/llvm/llvm-project/pull/78569


More information about the llvm-commits mailing list