[llvm] [DWARFYAML] Implement debug_names support (PR #79666)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 5 01:02:15 PST 2024


https://github.com/jh7370 commented:

I'm not massively familiar with the DWARF5 spec, so I haven't attempted to review that aspect of this PR and have restricted myself to coding style comments and more general YAML comments.

The testing seems a bit light to me. Are all new code paths tested? If nothing else, I don't see any testing of the error cases.

https://github.com/llvm/llvm-project/pull/79666


More information about the llvm-commits mailing list