[lld] [llvm] [Object][Wasm] Use file offset for section addresses in linked wasm files (PR #80529)

via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 2 22:46:51 PST 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 78b4e7c5e349d8c101b50affbd260eb109748f8f 9802ffd0bfb44b8956ec3c60c3ca4b63530e6726 -- llvm/lib/Object/WasmObjectFile.cpp llvm/lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp llvm/tools/llvm-objdump/llvm-objdump.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Object/WasmObjectFile.cpp b/llvm/lib/Object/WasmObjectFile.cpp
index 0fec053e25..8c1bbe9c26 100644
--- a/llvm/lib/Object/WasmObjectFile.cpp
+++ b/llvm/lib/Object/WasmObjectFile.cpp
@@ -1907,13 +1907,12 @@ Expected<StringRef> WasmObjectFile::getSectionName(DataRefImpl Sec) const {
 }
 
 uint64_t WasmObjectFile::getSectionAddress(DataRefImpl Sec) const {
-    // For object files, use 0 for section addresses, and section offsets for
-    // symbol addresses. For linked files, use file offsets.
-    // See also getSymbolAddress.
-      return isRelocatableObject() || isSharedObject()
-                              ? 0
-                              :  Sections[Sec.d.a].Offset;
-   }
+  // For object files, use 0 for section addresses, and section offsets for
+  // symbol addresses. For linked files, use file offsets.
+  // See also getSymbolAddress.
+  return isRelocatableObject() || isSharedObject() ? 0
+                                                   : Sections[Sec.d.a].Offset;
+}
 
 uint64_t WasmObjectFile::getSectionIndex(DataRefImpl Sec) const {
   return Sec.d.a;

``````````

</details>


https://github.com/llvm/llvm-project/pull/80529


More information about the llvm-commits mailing list