[llvm] [XCOFF] Add compiler version to an auxiliary symbol table entry (PR #80162)

David Tenty via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 2 14:37:49 PST 2024


================
@@ -902,7 +902,10 @@ void MCObjectStreamer::emitFileDirective(StringRef Filename,
                                          StringRef TimeStamp,
                                          StringRef Description) {
   getAssembler().addFileName(Filename);
-  // TODO: add additional info to integrated assembler.
+  if (!CompilerVerion.empty())
+    getAssembler().setCompilerVersion(CompilerVerion.data());
----------------
daltenty wrote:

Prefer str(), data() isn't necessarily null terminated according to the docs.

nit: can we fix the typo in the parameter name here while were at it? It shows up in the docs  🙂

```suggestion
    getAssembler().setCompilerVersion(CompilerVersion.str());
```

https://github.com/llvm/llvm-project/pull/80162


More information about the llvm-commits mailing list