[llvm] 4cf2ed4 - [X86] Fix -Wsign-compare in X86MCInstLower.cpp (NFC)
Jie Fu via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 2 03:41:54 PST 2024
Author: Jie Fu
Date: 2024-02-02T19:41:06+08:00
New Revision: 4cf2ed4396ddeda1487d6c5151a7dfdf14573920
URL: https://github.com/llvm/llvm-project/commit/4cf2ed4396ddeda1487d6c5151a7dfdf14573920
DIFF: https://github.com/llvm/llvm-project/commit/4cf2ed4396ddeda1487d6c5151a7dfdf14573920.diff
LOG: [X86] Fix -Wsign-compare in X86MCInstLower.cpp (NFC)
llvm-project/llvm/lib/Target/X86/X86MCInstLower.cpp:1588:48:
error: comparison of integers of different signs: 'unsigned int' and 'int' [-Werror,-Wsign-compare]
if (C && C->getType()->getScalarSizeInBits() == SrcEltBits) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~
1 error generated.
Added:
Modified:
llvm/lib/Target/X86/X86MCInstLower.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Target/X86/X86MCInstLower.cpp b/llvm/lib/Target/X86/X86MCInstLower.cpp
index 55d7868c53053..1a26489460882 100644
--- a/llvm/lib/Target/X86/X86MCInstLower.cpp
+++ b/llvm/lib/Target/X86/X86MCInstLower.cpp
@@ -1585,7 +1585,7 @@ static void printBroadcast(const MachineInstr *MI, MCStreamer &OutStreamer,
static bool printSignExtend(const MachineInstr *MI, MCStreamer &OutStreamer,
int SrcEltBits, int DstEltBits) {
auto *C = X86::getConstantFromPool(*MI, 1);
- if (C && C->getType()->getScalarSizeInBits() == SrcEltBits) {
+ if (C && C->getType()->getScalarSizeInBits() == unsigned(SrcEltBits)) {
if (auto *CDS = dyn_cast<ConstantDataSequential>(C)) {
int NumElts = CDS->getNumElements();
std::string Comment;
More information about the llvm-commits
mailing list