[llvm] [APInt] Assert correct values in APInt constructor (PR #80309)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 2 02:43:00 PST 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 62ae7d976f494f3dbd297331b19cd1204750de6f 506aaa1538c93a6adbd491a93e8454f9a25f0103 -- llvm/include/llvm/ADT/APFixedPoint.h llvm/include/llvm/ADT/APInt.h llvm/lib/Analysis/ConstantFolding.cpp llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp llvm/lib/FuzzMutate/OpDescriptor.cpp llvm/lib/IR/ConstantRange.cpp llvm/lib/Support/APInt.cpp llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp llvm/unittests/ADT/APFixedPointTest.cpp llvm/unittests/ADT/APIntTest.cpp llvm/unittests/ADT/APSIntTest.cpp llvm/unittests/ADT/StringExtrasTest.cpp llvm/unittests/Analysis/ScalarEvolutionTest.cpp llvm/unittests/FuzzMutate/RandomIRBuilderTest.cpp llvm/unittests/IR/ConstantRangeTest.cpp llvm/unittests/IR/ConstantsTest.cpp llvm/unittests/IR/InstructionsTest.cpp llvm/unittests/IR/MetadataTest.cpp llvm/unittests/IR/PatternMatch.cpp llvm/unittests/Support/DivisionByConstantTest.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/unittests/ADT/APIntTest.cpp b/llvm/unittests/ADT/APIntTest.cpp
index 3762d21b6e..6376389af8 100644
--- a/llvm/unittests/ADT/APIntTest.cpp
+++ b/llvm/unittests/ADT/APIntTest.cpp
@@ -1109,10 +1109,10 @@ TEST(APIntTest, fromString) {
EXPECT_EQ(APInt(32, 3), APInt(32, "+11", 2));
EXPECT_EQ(APInt(32, 4), APInt(32, "+100", 2));
- EXPECT_EQ(APInt(32, uint32_t(-0LL)), APInt(32, "-0", 2));
- EXPECT_EQ(APInt(32, uint32_t(-1LL)), APInt(32, "-1", 2));
- EXPECT_EQ(APInt(32, uint32_t(-2LL)), APInt(32, "-10", 2));
- EXPECT_EQ(APInt(32, uint32_t(-3LL)), APInt(32, "-11", 2));
+ EXPECT_EQ(APInt(32, uint32_t(-0LL)), APInt(32, "-0", 2));
+ EXPECT_EQ(APInt(32, uint32_t(-1LL)), APInt(32, "-1", 2));
+ EXPECT_EQ(APInt(32, uint32_t(-2LL)), APInt(32, "-10", 2));
+ EXPECT_EQ(APInt(32, uint32_t(-3LL)), APInt(32, "-11", 2));
EXPECT_EQ(APInt(32, uint32_t(-4LL)), APInt(32, "-100", 2));
EXPECT_EQ(APInt(32, 0), APInt(32, "0", 8));
@@ -1129,12 +1129,12 @@ TEST(APIntTest, fromString) {
EXPECT_EQ(APInt(32, +15), APInt(32, "+17", 8));
EXPECT_EQ(APInt(32, +16), APInt(32, "+20", 8));
- EXPECT_EQ(APInt(32, uint32_t(-0LL)), APInt(32, "-0", 8));
- EXPECT_EQ(APInt(32, uint32_t(-1LL)), APInt(32, "-1", 8));
- EXPECT_EQ(APInt(32, uint32_t(-7LL)), APInt(32, "-7", 8));
- EXPECT_EQ(APInt(32, uint32_t(-8LL)), APInt(32, "-10", 8));
- EXPECT_EQ(APInt(32, uint32_t(-15LL)), APInt(32, "-17", 8));
- EXPECT_EQ(APInt(32, uint32_t(-16LL)), APInt(32, "-20", 8));
+ EXPECT_EQ(APInt(32, uint32_t(-0LL)), APInt(32, "-0", 8));
+ EXPECT_EQ(APInt(32, uint32_t(-1LL)), APInt(32, "-1", 8));
+ EXPECT_EQ(APInt(32, uint32_t(-7LL)), APInt(32, "-7", 8));
+ EXPECT_EQ(APInt(32, uint32_t(-8LL)), APInt(32, "-10", 8));
+ EXPECT_EQ(APInt(32, uint32_t(-15LL)), APInt(32, "-17", 8));
+ EXPECT_EQ(APInt(32, uint32_t(-16LL)), APInt(32, "-20", 8));
EXPECT_EQ(APInt(32, 0), APInt(32, "0", 10));
EXPECT_EQ(APInt(32, 1), APInt(32, "1", 10));
@@ -1143,9 +1143,9 @@ TEST(APIntTest, fromString) {
EXPECT_EQ(APInt(32, 19), APInt(32, "19", 10));
EXPECT_EQ(APInt(32, 20), APInt(32, "20", 10));
- EXPECT_EQ(APInt(32, uint32_t(-0LL)), APInt(32, "-0", 10));
- EXPECT_EQ(APInt(32, uint32_t(-1LL)), APInt(32, "-1", 10));
- EXPECT_EQ(APInt(32, uint32_t(-9LL)), APInt(32, "-9", 10));
+ EXPECT_EQ(APInt(32, uint32_t(-0LL)), APInt(32, "-0", 10));
+ EXPECT_EQ(APInt(32, uint32_t(-1LL)), APInt(32, "-1", 10));
+ EXPECT_EQ(APInt(32, uint32_t(-9LL)), APInt(32, "-9", 10));
EXPECT_EQ(APInt(32, uint32_t(-10LL)), APInt(32, "-10", 10));
EXPECT_EQ(APInt(32, uint32_t(-19LL)), APInt(32, "-19", 10));
EXPECT_EQ(APInt(32, uint32_t(-20LL)), APInt(32, "-20", 10));
@@ -1157,9 +1157,9 @@ TEST(APIntTest, fromString) {
EXPECT_EQ(APInt(32, 31), APInt(32, "1F", 16));
EXPECT_EQ(APInt(32, 32), APInt(32, "20", 16));
- EXPECT_EQ(APInt(32, uint32_t(-0LL)), APInt(32, "-0", 16));
- EXPECT_EQ(APInt(32, uint32_t(-1LL)), APInt(32, "-1", 16));
- EXPECT_EQ(APInt(32, uint32_t(-15LL)), APInt(32, "-F", 16));
+ EXPECT_EQ(APInt(32, uint32_t(-0LL)), APInt(32, "-0", 16));
+ EXPECT_EQ(APInt(32, uint32_t(-1LL)), APInt(32, "-1", 16));
+ EXPECT_EQ(APInt(32, uint32_t(-15LL)), APInt(32, "-F", 16));
EXPECT_EQ(APInt(32, uint32_t(-16LL)), APInt(32, "-10", 16));
EXPECT_EQ(APInt(32, uint32_t(-31LL)), APInt(32, "-1F", 16));
EXPECT_EQ(APInt(32, uint32_t(-32LL)), APInt(32, "-20", 16));
@@ -1171,9 +1171,9 @@ TEST(APIntTest, fromString) {
EXPECT_EQ(APInt(32, 71), APInt(32, "1Z", 36));
EXPECT_EQ(APInt(32, 72), APInt(32, "20", 36));
- EXPECT_EQ(APInt(32, uint32_t(-0LL)), APInt(32, "-0", 36));
- EXPECT_EQ(APInt(32, uint32_t(-1LL)), APInt(32, "-1", 36));
- EXPECT_EQ(APInt(32, uint32_t(-35LL)), APInt(32, "-Z", 36));
+ EXPECT_EQ(APInt(32, uint32_t(-0LL)), APInt(32, "-0", 36));
+ EXPECT_EQ(APInt(32, uint32_t(-1LL)), APInt(32, "-1", 36));
+ EXPECT_EQ(APInt(32, uint32_t(-35LL)), APInt(32, "-Z", 36));
EXPECT_EQ(APInt(32, uint32_t(-36LL)), APInt(32, "-10", 36));
EXPECT_EQ(APInt(32, uint32_t(-71LL)), APInt(32, "-1Z", 36));
EXPECT_EQ(APInt(32, uint32_t(-72LL)), APInt(32, "-20", 36));
diff --git a/llvm/unittests/IR/ConstantRangeTest.cpp b/llvm/unittests/IR/ConstantRangeTest.cpp
index c1adb30ab9..6e6df72a10 100644
--- a/llvm/unittests/IR/ConstantRangeTest.cpp
+++ b/llvm/unittests/IR/ConstantRangeTest.cpp
@@ -994,8 +994,8 @@ TEST_F(ConstantRangeTest, Multiply) {
ConstantRange(APInt(8, 250), APInt(8, 253)));
// TODO: This should be return [-2, 0]
- EXPECT_EQ(ConstantRange(APInt(8, -2, true)).multiply(
- ConstantRange(APInt(8, 0), APInt(8, 2))),
+ EXPECT_EQ(ConstantRange(APInt(8, -2, true))
+ .multiply(ConstantRange(APInt(8, 0), APInt(8, 2))),
ConstantRange(APInt(8, -2, true), APInt(8, 1)));
// Multiplication by -1 should give precise results.
@@ -1073,11 +1073,11 @@ TEST_F(ConstantRangeTest, SMax) {
EXPECT_EQ(Empty.smax(Wrap), Empty);
EXPECT_EQ(Empty.smax(One), Empty);
EXPECT_EQ(Some.smax(Some), Some);
- EXPECT_EQ(Some.smax(Wrap), ConstantRange(APInt(16, 0xa),
- APInt(16, (uint16_t)INT16_MIN)));
+ EXPECT_EQ(Some.smax(Wrap),
+ ConstantRange(APInt(16, 0xa), APInt(16, (uint16_t)INT16_MIN)));
EXPECT_EQ(Some.smax(One), Some);
- EXPECT_EQ(Wrap.smax(One), ConstantRange(APInt(16, 0xa),
- APInt(16, (uint16_t)INT16_MIN)));
+ EXPECT_EQ(Wrap.smax(One),
+ ConstantRange(APInt(16, 0xa), APInt(16, (uint16_t)INT16_MIN)));
EXPECT_EQ(One.smax(One), One);
TestBinaryOpExhaustive(
diff --git a/llvm/unittests/IR/InstructionsTest.cpp b/llvm/unittests/IR/InstructionsTest.cpp
index cbd121e4ce..f513aa3dc1 100644
--- a/llvm/unittests/IR/InstructionsTest.cpp
+++ b/llvm/unittests/IR/InstructionsTest.cpp
@@ -51,7 +51,7 @@ TEST(InstructionsTest, ReturnInst) {
EXPECT_EQ(r0->op_begin(), r0->op_end());
IntegerType* Int1 = IntegerType::get(C, 1);
- Constant* One = ConstantInt::get(Int1, 1);
+ Constant *One = ConstantInt::get(Int1, 1);
const ReturnInst* r1 = ReturnInst::Create(C, One);
EXPECT_EQ(1U, r1->getNumOperands());
User::const_op_iterator b(r1->op_begin());
@@ -150,7 +150,7 @@ TEST(InstructionsTest, BranchInst) {
EXPECT_EQ(b0->op_end(), std::next(b0->op_begin()));
IntegerType* Int1 = IntegerType::get(C, 1);
- Constant* One = ConstantInt::get(Int1, 1);
+ Constant *One = ConstantInt::get(Int1, 1);
// Conditional BranchInst
BranchInst* b1 = BranchInst::Create(bb0, bb1, One);
``````````
</details>
https://github.com/llvm/llvm-project/pull/80309
More information about the llvm-commits
mailing list