[llvm] 42ec993 - [PowerPC] Fix gcc -Wparentheses warning [NFC]

Mikael Holmen via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 2 01:51:33 PST 2024


Author: Mikael Holmen
Date: 2024-02-02T10:50:47+01:00
New Revision: 42ec9934e1079742e0b5d839e420bc3f746fc73b

URL: https://github.com/llvm/llvm-project/commit/42ec9934e1079742e0b5d839e420bc3f746fc73b
DIFF: https://github.com/llvm/llvm-project/commit/42ec9934e1079742e0b5d839e420bc3f746fc73b.diff

LOG: [PowerPC] Fix gcc -Wparentheses warning [NFC]

Without this gcc warns like
 ../lib/Target/PowerPC/PPCAsmPrinter.cpp:1650:33: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
  1650 |            (InstDisp >= -32768) &&
       |            ~~~~~~~~~~~~~~~~~~~~~^~
  1651 |                "Expecting the instruction displacement for local-exec TLS "
       |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  1652 |                "variables to be between [-32768, 32768)!");
       |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Added: 
    

Modified: 
    llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp b/llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
index b75501e8bae52..a965d6b70d2d9 100644
--- a/llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
+++ b/llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
@@ -1646,8 +1646,8 @@ const MCExpr *PPCAsmPrinter::getAdjustedLocalExecExpr(const MachineOperand &MO,
     ptr
diff _t Delta = ((FinalAddress + 32768) & ~0xFFFF);
     // Check that the total instruction displacement fits within [-32768,32768).
     [[maybe_unused]] ptr
diff _t InstDisp = TLSVarAddress + Offset - Delta;
-    assert((InstDisp < 32768) ||
-           (InstDisp >= -32768) &&
+    assert(((InstDisp < 32768) ||
+            (InstDisp >= -32768)) &&
                "Expecting the instruction displacement for local-exec TLS "
                "variables to be between [-32768, 32768)!");
     Expr = MCBinaryExpr::createAdd(


        


More information about the llvm-commits mailing list