[llvm] [InstCombine] Do not simplify lshr/shl arg if it is part of fshl rotate pattern. (PR #73441)

[via llvm-commits]

================
@@ -2706,17 +2706,16 @@ Instruction *InstCombinerImpl::matchBSwapOrBitReverse(Instruction &I,
   return LastInst;
 }
 
-/// Match UB-safe variants of the funnel shift intrinsic.
-static Instruction *matchFunnelShift(Instruction &Or, InstCombinerImpl &IC,
-                                     const DominatorTree &DT) {
+std::optional<std::tuple<Intrinsic::ID, SmallVector<Value *, 3>>>
----------------
quic-eikansh wrote:

Do `std::pair`  has advantage over `std::tuple`? I see `std::tuple` used in codebase even for 2 element. I have addressed other 2 reviews.

https://github.com/llvm/llvm-project/pull/73441