[llvm] [CSSPGO] Compute and report profile matching recovered callsites and samples (PR #79090)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 31 22:51:58 PST 2024
================
@@ -690,6 +715,10 @@ void SampleProfileLoaderBaseImpl<Function>::computeDominanceAndLoopInfo(
}
} // namespace llvm
+bool ShouldSkipProfileLoading(const Function &F) {
----------------
WenleiHe wrote:
1. make this static -- other free functions specific to sample loader are static.
2. if make this into a helper function, all similar code should be replaced. there are 5+ instance but only one is replaced in this change.
3. function name starts with lower case
4. nit: name it `skipProfileForFunction` or `useProfileForFunction`
https://github.com/llvm/llvm-project/pull/79090
More information about the llvm-commits
mailing list