[llvm] [CFI][annotation] Leave alone function pointers in function annotations (PR #80173)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 31 13:58:56 PST 2024


================
@@ -470,6 +470,9 @@ class LowerTypeTestsModule {
 
   Function *WeakInitializerFn = nullptr;
 
+  GlobalVariable *GlobalAnnotation;
+  std::set<void *> FunctionAnnotations;
----------------
nikic wrote:

Use SmallPtrSet or DenseSet, not std::set. Also, why does this use `void *` pointers? Shouldn't this be something like `GlobalValue *` or at the very least `Value *`?

https://github.com/llvm/llvm-project/pull/80173


More information about the llvm-commits mailing list