[llvm] [AMDGPU] Stop combining arbitrary offsets into PAL relocs (PR #80034)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 31 01:41:52 PST 2024


================
@@ -7133,6 +7133,17 @@ SDValue SITargetLowering::lowerBUILD_VECTOR(SDValue Op,
 
 bool
 SITargetLowering::isOffsetFoldingLegal(const GlobalAddressSDNode *GA) const {
+  // Subtargets that use ELF REL relocations (instead of RELA) can only store a
----------------
jayfoad wrote:

Can you suggest a better word? `Subtarget->isAmdHsaOS()` suggests that this *is* a property of the subtarget, or something else here is badly named.

https://github.com/llvm/llvm-project/pull/80034


More information about the llvm-commits mailing list