[llvm] [PseudoProbe] Extend to skip instrumenting probe into the dests of invoke (PR #79919)

via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 30 13:16:12 PST 2024


================
@@ -16,6 +16,7 @@ namespace llvm {
 /// Compute a list of blocks that are only reachable via EH paths.
 template <typename FunctionT, typename BlockT>
 static void computeEHOnlyBlocks(FunctionT &F, DenseSet<BlockT *> &EHBlocks) {
+  assert(EHBlocks.empty() && "Output set should be empty");
----------------
WenleiHe wrote:

I understand that you want to make sure we don't do `findInvokeNormalDests` first, only to have it cleared here. But this assertion is not compatible with the `EHBlocks.clear()` later in this function. If we clear it explicit, we are not expecting it to be empty, vice versa. 

https://github.com/llvm/llvm-project/pull/79919


More information about the llvm-commits mailing list