[llvm] 8582d41 - [Target] Use SDValue::getConstantOperandVal (NFC)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 29 18:46:28 PST 2024
Author: Kazu Hirata
Date: 2024-01-29T18:46:16-08:00
New Revision: 8582d41789ef8524e72e9c5d5eab305455c8d6bc
URL: https://github.com/llvm/llvm-project/commit/8582d41789ef8524e72e9c5d5eab305455c8d6bc
DIFF: https://github.com/llvm/llvm-project/commit/8582d41789ef8524e72e9c5d5eab305455c8d6bc.diff
LOG: [Target] Use SDValue::getConstantOperandVal (NFC)
Added:
Modified:
llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
llvm/lib/Target/AMDGPU/SIISelLowering.cpp
llvm/lib/Target/X86/X86ISelLowering.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp b/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
index 4f7bf3f7d35e7..07997b7e1678a 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
@@ -1474,7 +1474,7 @@ bool AMDGPUDAGToDAGISel::SelectMUBUFScratchOffen(SDNode *Parent,
// (add n0, c1)
SDValue N0 = Addr.getOperand(0);
- SDValue N1 = Addr.getOperand(1);
+ uint64_t C1 = Addr.getConstantOperandVal(1);
// Offsets in vaddr must be positive if range checking is enabled.
//
@@ -1492,12 +1492,11 @@ bool AMDGPUDAGToDAGISel::SelectMUBUFScratchOffen(SDNode *Parent,
// MUBUF vaddr, but not on older subtargets which can only do this if the
// sign bit is known 0.
const SIInstrInfo *TII = Subtarget->getInstrInfo();
- ConstantSDNode *C1 = cast<ConstantSDNode>(N1);
- if (TII->isLegalMUBUFImmOffset(C1->getZExtValue()) &&
+ if (TII->isLegalMUBUFImmOffset(C1) &&
(!Subtarget->privateMemoryResourceIsRangeChecked() ||
CurDAG->SignBitIsZero(N0))) {
std::tie(VAddr, SOffset) = foldFrameIndex(N0);
- ImmOffset = CurDAG->getTargetConstant(C1->getZExtValue(), DL, MVT::i32);
+ ImmOffset = CurDAG->getTargetConstant(C1, DL, MVT::i32);
return true;
}
}
diff --git a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
index 0137dfa8d5fbe..7ab062bcc4da7 100644
--- a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
+++ b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
@@ -7686,10 +7686,10 @@ SDValue SITargetLowering::lowerImage(SDValue Op,
if (!BaseOpcode->Sampler) {
Unorm = True;
} else {
- auto UnormConst =
- cast<ConstantSDNode>(Op.getOperand(ArgOffset + Intr->UnormIndex));
+ uint64_t UnormConst =
+ Op.getConstantOperandVal(ArgOffset + Intr->UnormIndex);
- Unorm = UnormConst->getZExtValue() ? True : False;
+ Unorm = UnormConst ? True : False;
}
SDValue TFE;
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index 4ae27d9f46bb9..ec796dc2231f8 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -25841,9 +25841,8 @@ SDValue X86TargetLowering::LowerINTRINSIC_WO_CHAIN(SDValue Op,
assert(IntrData->Opc0 == X86ISD::VRNDSCALE && "Unexpected opcode");
// Clear the upper bits of the rounding immediate so that the legacy
// intrinsic can't trigger the scaling behavior of VRNDSCALE.
- auto Round = cast<ConstantSDNode>(Op.getOperand(2));
- SDValue RoundingMode =
- DAG.getTargetConstant(Round->getZExtValue() & 0xf, dl, MVT::i32);
+ uint64_t Round = Op.getConstantOperandVal(2);
+ SDValue RoundingMode = DAG.getTargetConstant(Round & 0xf, dl, MVT::i32);
return DAG.getNode(IntrData->Opc0, dl, Op.getValueType(),
Op.getOperand(1), RoundingMode);
}
@@ -25851,9 +25850,8 @@ SDValue X86TargetLowering::LowerINTRINSIC_WO_CHAIN(SDValue Op,
assert(IntrData->Opc0 == X86ISD::VRNDSCALES && "Unexpected opcode");
// Clear the upper bits of the rounding immediate so that the legacy
// intrinsic can't trigger the scaling behavior of VRNDSCALE.
- auto Round = cast<ConstantSDNode>(Op.getOperand(3));
- SDValue RoundingMode =
- DAG.getTargetConstant(Round->getZExtValue() & 0xf, dl, MVT::i32);
+ uint64_t Round = Op.getConstantOperandVal(3);
+ SDValue RoundingMode = DAG.getTargetConstant(Round & 0xf, dl, MVT::i32);
return DAG.getNode(IntrData->Opc0, dl, Op.getValueType(),
Op.getOperand(1), Op.getOperand(2), RoundingMode);
}
More information about the llvm-commits
mailing list