[llvm] [DebugInfo] Make DIExpression inherit from Metadata and it always should be unique (PR #79335)

Adrian Prantl via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 29 14:58:00 PST 2024


================
@@ -2656,31 +2656,27 @@ class DIVariable : public DINode {
 /// DW_OP_stack_value) is the constant variable value.
 ///
 /// TODO: Co-allocate the expression elements.
-/// TODO: Separate from MDNode, or otherwise drop Distinct and Temporary
-/// storage types.
-class DIExpression : public MDNode {
+class DIExpression : public Metadata, ReplaceableMetadataImpl {
----------------
adrian-prantl wrote:

Should we document why DIExpression is not an MDNode here?

https://github.com/llvm/llvm-project/pull/79335


More information about the llvm-commits mailing list