[llvm] [libc++][ci] Use upload-artifact at v4 instead of @v3 (PR #79854)

[Louis Dionne via llvm-commits]

https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/79854

The upload-artifact at v3 action is using Node 16, which is reaching EOL. As a result, we are getting warnings prompting us to move our jobs over to the latest version of upload-artifact.

>From 619f2e342bd332af3222e0fcd36a8c5a27fc2d05 Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Mon, 29 Jan 2024 11:04:07 -0500
Subject: [PATCH] [libc++][ci] Use upload-artifact at v4 instead of @v3

The upload-artifact at v3 action is using Node 16, which is reaching EOL.
As a result, we are getting warnings prompting us to move our jobs
over to the latest version of upload-artifact.
---
 .github/workflows/libcxx-build-and-test.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index 9579c05f1c5b1a..ba5a63eac8bf8b 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -75,7 +75,7 @@ jobs:
           CC: ${{ matrix.cc }}
           CXX: ${{ matrix.cxx }}
           ENABLE_CLANG_TIDY: ${{ matrix.clang_tidy }}
-      - uses: actions/upload-artifact at v3
+      - uses: actions/upload-artifact at v4
         if: always()
         with:
           name: ${{ matrix.config }}-${{ matrix.cxx }}-results
@@ -124,7 +124,7 @@ jobs:
           CC: ${{ matrix.cc }}
           CXX: ${{ matrix.cxx }}
           ENABLE_CLANG_TIDY: ${{ matrix.clang_tidy }}
-      - uses: actions/upload-artifact at v3
+      - uses: actions/upload-artifact at v4
         if: always()  # Upload artifacts even if the build or test suite fails
         with:
           name: ${{ matrix.config }}-results
@@ -189,7 +189,7 @@ jobs:
           CC: clang-18
           CXX: clang++-18
           ENABLE_CLANG_TIDY: "OFF"
-      - uses: actions/upload-artifact at v3
+      - uses: actions/upload-artifact at v4
         if: always()
         with:
           name: ${{ matrix.config }}-results