[llvm] [RemoveDIs] Print non-intrinsic debug info in textual IR output (PR #79281)

Stephen Tozer via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 29 05:10:06 PST 2024


SLTozer wrote:

> If `{}` is used, I would generally expect something list-like. This may be an ordered (metadata, struct) or an unordered (attributes) list, but I would expect that I can specify an arbitrary number of arbitrary elements.

That's reasonable, I'm fine with either format - the thought process is that debug records should be understandable and visually distinct from instructions; if using braces hurts understanding (by creating a false expectation about the nature of the parameter list) then parentheses will be fine, since the records are still distinct from instructions (firstly by the `#` prefix and secondly by indentation) - though if anyone else has thoughts about what the brackets should or shouldn't be, the discussion is still open of course.

https://github.com/llvm/llvm-project/pull/79281


More information about the llvm-commits mailing list