[llvm] [RISCV][NFC] Remove unused methods of tuimm5 (PR #79680)

Jianjian Guan via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 26 22:55:01 PST 2024


https://github.com/jacquesguan created https://github.com/llvm/llvm-project/pull/79680

Since we only use tuimm5 in patterns, it doesn't need those methods for MC layer. And there is not `getUImmOpValue` defination now, leave those methods is confusing.

>From ade80e7f616d789063c59254298b538556295271 Mon Sep 17 00:00:00 2001
From: Jianjian GUAN <jacquesguan at me.com>
Date: Sat, 27 Jan 2024 14:44:25 +0800
Subject: [PATCH] [RISCV][NFC] Remove unused methods of tuimm5

Since we only use tuimm5 in patterns, it doesn't need those methods for MC layer. And there is not `getUImmOpValue` defination now, leave those methods is confusing.
---
 llvm/lib/Target/RISCV/RISCVInstrInfoZvk.td | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/llvm/lib/Target/RISCV/RISCVInstrInfoZvk.td b/llvm/lib/Target/RISCV/RISCVInstrInfoZvk.td
index 7c21fb4bcc1ea64..b4bd074b710179a 100644
--- a/llvm/lib/Target/RISCV/RISCVInstrInfoZvk.td
+++ b/llvm/lib/Target/RISCV/RISCVInstrInfoZvk.td
@@ -15,17 +15,7 @@
 // Operand and SDNode transformation definitions.
 //===----------------------------------------------------------------------===//
 
-def tuimm5 : Operand<XLenVT>, TImmLeaf<XLenVT, [{return isUInt<5>(Imm);}]> {
-  let ParserMatchClass = UImmAsmOperand<5>;
-  let EncoderMethod = "getUImmOpValue";
-  let DecoderMethod = "decodeUImmOperand<5>";
-  let MCOperandPredicate = [{
-    int64_t UImm;
-    if (MCOp.evaluateAsConstantImm(UImm))
-      return isUInt<5>(UImm);
-    return MCOp.isBareSymbolRef();
-  }];
-}
+def tuimm5 : RISCVOp, TImmLeaf<XLenVT, [{return isUInt<5>(Imm);}]>;
 
 //===----------------------------------------------------------------------===//
 // Instruction class templates



More information about the llvm-commits mailing list