[llvm] Aggregate errors from llvm-dwarfutil --verify (PR #79648)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 26 15:34:17 PST 2024


================
@@ -50,7 +50,11 @@
 # CHECK-NEXT:               DW_AT_decl_line   [DW_FORM_sdata] (3)
 # CHECK-NEXT:               DW_AT_call_file   [DW_FORM_sdata] (4)
 # CHECK-NEXT:               DW_AT_call_line   [DW_FORM_sdata] (5){{[[:space:]]}}
-
+# CHECK-NEXT: Verifying dwo Units...
+# CHECK-NEXT: error: Aggregated error category counts:
+# CHECK-NEXT: error: Error category 'Invalid encoding in DW_AT_decl_file' occurred 4 time(s).
----------------
dwblaikie wrote:

Not sure we need the word 'category' in here? and usually diagnostics are all lower case, I think? (though maybe `error: error 'Invalid encoding in DW_AT_decl_file' occurred 4 time(s).` is a bit hard to parse.. (perhaps these shouldn't be printed as errors? It is a bit weird having a whole multiline report each prefixed with `error:`, maybe?) (though it also shows these diagnostics don't follow the lowercase habit either... which is unfortunate))

https://github.com/llvm/llvm-project/pull/79648


More information about the llvm-commits mailing list