[llvm] [Exegesis] Do not assume the size and layout of the assembled snippet (PR #79636)

Min-Yih Hsu via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 26 15:19:30 PST 2024


mshockwave wrote:

> One nit. Otherwise LGTM.
> 
> Thanks for fixing this. Is it possible to have a test in-tree for this or is the object file code for that downstream as well? It would be nice to have a test if possible. 

I thought about this, ideally we could insert an artificially-created object file with more than 3 symbols right before we ran it with JIT. But  IIUC llvm-exegesis currently lacks such functionality (I think using snippet file as input doesn't exercise this program path) so it would be difficult to write a test at this moment.

https://github.com/llvm/llvm-project/pull/79636


More information about the llvm-commits mailing list