[llvm] [AMDGPU][MC] Support src modifiers for v_mov_b32 and v_movrel* instructions (PR #76498)

Joe Nash via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 26 08:47:31 PST 2024


================
@@ -222,6 +222,13 @@ def VOPProfile_MOV : VOPProfile <[i32, i32, untyped, untyped]> {
   let InsVOPDXDeferred = (ins VSrc_f32_Deferred:$src0X);
   let InsVOPDY = (ins Src0RC32:$src0Y);
   let InsVOPDYDeferred = (ins VSrc_f32_Deferred:$src0Y);
+
+  let HasModifiers = 1;
+  let HasClamp = 1;
+
----------------
Sisyph wrote:

> I would say that there is no need for v_mov_b32 with modifiers. It can always be xor/and/or with constant or some other instruction. I can't think of any reasonable use case. We're just introducing special cases in a lot of places.
> 
> I would exclude v_mov_b32 from this patch and just focus on other instructions. Unless you know of any case where this would be valuable?

I agree. Excluding v_mov_b32 from the patch because it is difficult to support in all the cases and not that useful is a good solution.

https://github.com/llvm/llvm-project/pull/76498


More information about the llvm-commits mailing list