davemgreen wrote: Sorry I don't think I got the update for the latest update. Thanks for splitting this out. It looks like the tests might be failing in CI, but otherwise this LGTM. https://github.com/llvm/llvm-project/pull/79003