[llvm] [llvm-objcopy] Support SREC output format (PR #75874)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 26 00:36:39 PST 2024


================
@@ -2847,24 +2847,24 @@ void SRECSectionWriter::writeRecord(SRecord &Record, uint64_t Off) {
   memcpy(Out.getBufferStart() + Off, Data.data(), Data.size());
 }
 
-void SRECSectionWriter::writeRecords(uint32_t Entry) {
+void SRECSizeCalculator::writeRecords(uint32_t Entry) {
----------------
jh7370 wrote:

Taking another look at this and it's not really ideal that we have to do two passes through the records (one for sizing and one for writing). I'm sure there's a reason to do it this way, but what is it, as that might inform an alternative approach?

https://github.com/llvm/llvm-project/pull/75874


More information about the llvm-commits mailing list