[llvm] [llvm-objcopy] Support SREC output format (PR #75874)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 26 00:36:38 PST 2024


================
@@ -2987,7 +2987,7 @@ size_t SRECWriter::writeTerminator(uint8_t *Buf, uint8_t Type) {
 
 Expected<size_t>
 SRECWriter::getTotalSize(WritableMemoryBuffer &EmptyBuffer) const {
-  SRECSectionWriterBase LengthCalc(EmptyBuffer, 0);
+  SRECSizeCalculator LengthCalc(EmptyBuffer, 0);
----------------
jh7370 wrote:

Nit: it feels a bit off to be mixing the terms "Length" and "Size" for the same thing. I don't mind which you use (although I think "Size" is more common in general), but I'd be consistent.

https://github.com/llvm/llvm-project/pull/75874


More information about the llvm-commits mailing list