[llvm] [InstCombine] Precommit test for #79417. NFC. (PR #79418)

Kai Luo via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 25 21:08:52 PST 2024


https://github.com/bzEq updated https://github.com/llvm/llvm-project/pull/79418

>From 85360d691b8572a1f2d6e42f11dd2694b194507a Mon Sep 17 00:00:00 2001
From: Kai Luo <lkail at cn.ibm.com>
Date: Thu, 25 Jan 2024 07:48:50 +0000
Subject: [PATCH 1/2] Add test

---
 llvm/test/CodeGen/AArch64/absdiff.ll          | 18 +++++++++++++++
 llvm/test/CodeGen/PowerPC/absdiff.ll          | 19 ++++++++++++++++
 llvm/test/CodeGen/X86/absdiff.ll              | 22 +++++++++++++++++++
 .../Transforms/InstCombine/sub-xor-cmp.ll     | 20 +++++++++++++++++
 4 files changed, 79 insertions(+)
 create mode 100644 llvm/test/CodeGen/AArch64/absdiff.ll
 create mode 100644 llvm/test/CodeGen/PowerPC/absdiff.ll
 create mode 100644 llvm/test/CodeGen/X86/absdiff.ll
 create mode 100644 llvm/test/Transforms/InstCombine/sub-xor-cmp.ll

diff --git a/llvm/test/CodeGen/AArch64/absdiff.ll b/llvm/test/CodeGen/AArch64/absdiff.ll
new file mode 100644
index 000000000000000..ca7b5a583cbe51e
--- /dev/null
+++ b/llvm/test/CodeGen/AArch64/absdiff.ll
@@ -0,0 +1,18 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4
+; RUN: opt -mtriple=aarch64-linux-gnu -passes=instcombine < %s -o - | llc -mtriple=aarch64-linux-gnu -o - | FileCheck %s
+
+define  i64 @absdiff(i64 %0, i64 %1) {
+; CHECK-LABEL: absdiff:
+; CHECK:       // %bb.0:
+; CHECK-NEXT:    subs x8, x0, x1
+; CHECK-NEXT:    csetm x9, lo
+; CHECK-NEXT:    cinv x8, x8, lo
+; CHECK-NEXT:    sub x0, x8, x9
+; CHECK-NEXT:    ret
+  %3 = icmp ult i64 %0, %1
+  %4 = sext i1 %3 to i64
+  %5 = sub i64 %0, %1
+  %6 = xor i64 %5, %4
+  %7 = sub i64 %6, %4
+  ret i64 %7
+}
diff --git a/llvm/test/CodeGen/PowerPC/absdiff.ll b/llvm/test/CodeGen/PowerPC/absdiff.ll
new file mode 100644
index 000000000000000..a26482fc6497b8a
--- /dev/null
+++ b/llvm/test/CodeGen/PowerPC/absdiff.ll
@@ -0,0 +1,19 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4
+; RUN: opt -mtriple=powerpc64-linux-gnu -passes=instcombine < %s -o - | llc -mtriple=powerpc64-linux-gnu -o - | FileCheck %s
+
+define  i64 @absdiff(i64 %0, i64 %1) {
+; CHECK-LABEL: absdiff:
+; CHECK:       # %bb.0:
+; CHECK-NEXT:    subc 5, 3, 4
+; CHECK-NEXT:    subfe 5, 3, 3
+; CHECK-NEXT:    sub 3, 3, 4
+; CHECK-NEXT:    xor 3, 3, 5
+; CHECK-NEXT:    sub 3, 3, 5
+; CHECK-NEXT:    blr
+  %3 = icmp ult i64 %0, %1
+  %4 = sext i1 %3 to i64
+  %5 = sub i64 %0, %1
+  %6 = xor i64 %5, %4
+  %7 = sub i64 %6, %4
+  ret i64 %7
+}
diff --git a/llvm/test/CodeGen/X86/absdiff.ll b/llvm/test/CodeGen/X86/absdiff.ll
new file mode 100644
index 000000000000000..46c7b62e43685b7
--- /dev/null
+++ b/llvm/test/CodeGen/X86/absdiff.ll
@@ -0,0 +1,22 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4
+; RUN: opt -mtriple=x86_64-linux-gnu -passes=instcombine < %s -o - | llc -mtriple=x86_64-linux-gnu -o - | FileCheck %s
+
+define  i64 @absdiff(i64 %0, i64 %1) {
+; CHECK-LABEL: absdiff:
+; CHECK:       # %bb.0:
+; CHECK-NEXT:    xorl %eax, %eax
+; CHECK-NEXT:    movq %rdi, %rcx
+; CHECK-NEXT:    subq %rsi, %rcx
+; CHECK-NEXT:    setb %al
+; CHECK-NEXT:    negq %rax
+; CHECK-NEXT:    xorq %rcx, %rax
+; CHECK-NEXT:    cmpq %rsi, %rdi
+; CHECK-NEXT:    adcq $0, %rax
+; CHECK-NEXT:    retq
+  %3 = icmp ult i64 %0, %1
+  %4 = sext i1 %3 to i64
+  %5 = sub i64 %0, %1
+  %6 = xor i64 %5, %4
+  %7 = sub i64 %6, %4
+  ret i64 %7
+}
diff --git a/llvm/test/Transforms/InstCombine/sub-xor-cmp.ll b/llvm/test/Transforms/InstCombine/sub-xor-cmp.ll
new file mode 100644
index 000000000000000..0555bc1c365f5a4
--- /dev/null
+++ b/llvm/test/Transforms/InstCombine/sub-xor-cmp.ll
@@ -0,0 +1,20 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 4
+; RUN: opt < %s -passes=instcombine -S | FileCheck %s
+
+define  i64 @absdiff(i64 %0, i64 %1) {
+; CHECK-LABEL: define i64 @absdiff(
+; CHECK-SAME: i64 [[TMP0:%.*]], i64 [[TMP1:%.*]]) {
+; CHECK-NEXT:    [[TMP3:%.*]] = icmp ult i64 [[TMP0]], [[TMP1]]
+; CHECK-NEXT:    [[TMP4:%.*]] = sext i1 [[TMP3]] to i64
+; CHECK-NEXT:    [[TMP5:%.*]] = sub i64 [[TMP0]], [[TMP1]]
+; CHECK-NEXT:    [[TMP6:%.*]] = xor i64 [[TMP5]], [[TMP4]]
+; CHECK-NEXT:    [[TMP7:%.*]] = sub i64 [[TMP6]], [[TMP4]]
+; CHECK-NEXT:    ret i64 [[TMP7]]
+;
+  %3 = icmp ult i64 %0, %1
+  %4 = sext i1 %3 to i64
+  %5 = sub i64 %0, %1
+  %6 = xor i64 %5, %4
+  %7 = sub i64 %6, %4
+  ret i64 %7
+}

>From fd884cfae0478816f5625938d178be59757e0fd3 Mon Sep 17 00:00:00 2001
From: Kai Luo <gluokai at gmail.com>
Date: Fri, 26 Jan 2024 12:53:14 +0800
Subject: [PATCH 2/2] Remove codegen tests

---
 llvm/test/CodeGen/AArch64/absdiff.ll | 18 ------------------
 llvm/test/CodeGen/PowerPC/absdiff.ll | 19 -------------------
 llvm/test/CodeGen/X86/absdiff.ll     | 22 ----------------------
 3 files changed, 59 deletions(-)
 delete mode 100644 llvm/test/CodeGen/AArch64/absdiff.ll
 delete mode 100644 llvm/test/CodeGen/PowerPC/absdiff.ll
 delete mode 100644 llvm/test/CodeGen/X86/absdiff.ll

diff --git a/llvm/test/CodeGen/AArch64/absdiff.ll b/llvm/test/CodeGen/AArch64/absdiff.ll
deleted file mode 100644
index ca7b5a583cbe51e..000000000000000
--- a/llvm/test/CodeGen/AArch64/absdiff.ll
+++ /dev/null
@@ -1,18 +0,0 @@
-; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4
-; RUN: opt -mtriple=aarch64-linux-gnu -passes=instcombine < %s -o - | llc -mtriple=aarch64-linux-gnu -o - | FileCheck %s
-
-define  i64 @absdiff(i64 %0, i64 %1) {
-; CHECK-LABEL: absdiff:
-; CHECK:       // %bb.0:
-; CHECK-NEXT:    subs x8, x0, x1
-; CHECK-NEXT:    csetm x9, lo
-; CHECK-NEXT:    cinv x8, x8, lo
-; CHECK-NEXT:    sub x0, x8, x9
-; CHECK-NEXT:    ret
-  %3 = icmp ult i64 %0, %1
-  %4 = sext i1 %3 to i64
-  %5 = sub i64 %0, %1
-  %6 = xor i64 %5, %4
-  %7 = sub i64 %6, %4
-  ret i64 %7
-}
diff --git a/llvm/test/CodeGen/PowerPC/absdiff.ll b/llvm/test/CodeGen/PowerPC/absdiff.ll
deleted file mode 100644
index a26482fc6497b8a..000000000000000
--- a/llvm/test/CodeGen/PowerPC/absdiff.ll
+++ /dev/null
@@ -1,19 +0,0 @@
-; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4
-; RUN: opt -mtriple=powerpc64-linux-gnu -passes=instcombine < %s -o - | llc -mtriple=powerpc64-linux-gnu -o - | FileCheck %s
-
-define  i64 @absdiff(i64 %0, i64 %1) {
-; CHECK-LABEL: absdiff:
-; CHECK:       # %bb.0:
-; CHECK-NEXT:    subc 5, 3, 4
-; CHECK-NEXT:    subfe 5, 3, 3
-; CHECK-NEXT:    sub 3, 3, 4
-; CHECK-NEXT:    xor 3, 3, 5
-; CHECK-NEXT:    sub 3, 3, 5
-; CHECK-NEXT:    blr
-  %3 = icmp ult i64 %0, %1
-  %4 = sext i1 %3 to i64
-  %5 = sub i64 %0, %1
-  %6 = xor i64 %5, %4
-  %7 = sub i64 %6, %4
-  ret i64 %7
-}
diff --git a/llvm/test/CodeGen/X86/absdiff.ll b/llvm/test/CodeGen/X86/absdiff.ll
deleted file mode 100644
index 46c7b62e43685b7..000000000000000
--- a/llvm/test/CodeGen/X86/absdiff.ll
+++ /dev/null
@@ -1,22 +0,0 @@
-; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4
-; RUN: opt -mtriple=x86_64-linux-gnu -passes=instcombine < %s -o - | llc -mtriple=x86_64-linux-gnu -o - | FileCheck %s
-
-define  i64 @absdiff(i64 %0, i64 %1) {
-; CHECK-LABEL: absdiff:
-; CHECK:       # %bb.0:
-; CHECK-NEXT:    xorl %eax, %eax
-; CHECK-NEXT:    movq %rdi, %rcx
-; CHECK-NEXT:    subq %rsi, %rcx
-; CHECK-NEXT:    setb %al
-; CHECK-NEXT:    negq %rax
-; CHECK-NEXT:    xorq %rcx, %rax
-; CHECK-NEXT:    cmpq %rsi, %rdi
-; CHECK-NEXT:    adcq $0, %rax
-; CHECK-NEXT:    retq
-  %3 = icmp ult i64 %0, %1
-  %4 = sext i1 %3 to i64
-  %5 = sub i64 %0, %1
-  %6 = xor i64 %5, %4
-  %7 = sub i64 %6, %4
-  ret i64 %7
-}



More information about the llvm-commits mailing list