[llvm] [Coverage] Rework Decision/Expansion/Branch (PR #78969)

Alan Phipps via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 25 15:27:41 PST 2024


evodius96 wrote:

Thanks for working on this; I apologize I haven't been able to keep up.  As far as I can tell the benefits to this approach over https://github.com/llvm/llvm-project/pull/78819 are:

1. Records are processed as they're seen with no scan-ahead and therefore no possibility that a record will be needlessly visited multiple times.
2. The IDs of the branch regions in the decision are also tracked to ensure they're unique. Thus you can better flag malformed records as opposed to a missing TestVector assertion failure.
3. The Decision/Expansion/Branch processing is better encapsulated.

Is that right?

https://github.com/llvm/llvm-project/pull/78969


More information about the llvm-commits mailing list