https://github.com/aeubanks commented: general feedback: it seems like these sorts of PRs could be split for easier reviewing don't have to do it here, but something to keep in mind https://github.com/llvm/llvm-project/pull/70906