[llvm] 313d33e - [llvm-objdump, SHT_LLVM_BB_ADDR_MAP, NFC] Use auto && instead of const auto & to allow moving from BBAddrMap objects. (#79456)

[via llvm-commits]

Author: Rahman Lavaee
Date: 2024-01-25T13:03:18-08:00
New Revision: 313d33e33c7d379beb96cbf773ec3b98d1d2c6ed

URL: https://github.com/llvm/llvm-project/commit/313d33e33c7d379beb96cbf773ec3b98d1d2c6ed
DIFF: https://github.com/llvm/llvm-project/commit/313d33e33c7d379beb96cbf773ec3b98d1d2c6ed.diff

LOG: [llvm-objdump,SHT_LLVM_BB_ADDR_MAP,NFC] Use auto && instead of const auto & to allow moving from BBAddrMap objects. (#79456)

std::move on `const auto &` references is essentially a noop. Changing
to `auto &&` to actually allow moving.

Added: 
    

Modified: 
    llvm/tools/llvm-objdump/llvm-objdump.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/llvm-objdump/llvm-objdump.cpp b/llvm/tools/llvm-objdump/llvm-objdump.cpp
index 22b427f57658e1d..a80f4c2d9086524 100644
--- a/llvm/tools/llvm-objdump/llvm-objdump.cpp
+++ b/llvm/tools/llvm-objdump/llvm-objdump.cpp
@@ -1705,7 +1705,7 @@ disassembleObject(ObjectFile &Obj, const ObjectFile &DbgObj,
         reportWarning(toString(BBAddrMapsOrErr.takeError()), Obj.getFileName());
         return;
       }
-      for (const auto &[FunctionBBAddrMap, FunctionPGOAnalysis] :
+      for (auto &&[FunctionBBAddrMap, FunctionPGOAnalysis] :
            zip_equal(*std::move(BBAddrMapsOrErr), std::move(PGOAnalyses))) {
         uint64_t Addr = FunctionBBAddrMap.Addr;
         AddrToBBAddrMap.emplace(Addr, std::move(FunctionBBAddrMap));